fix: remove auto self-contained build for .NET 8 beanstalk deployments #847
Conversation
philasmar
force-pushed
the
asmarp/add-net8-beanstalk
branch
from
24c3d67 to
8ba5823
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #847 +/- ##
==========================================
+ Coverage 61.93% 62.39% +0.45%
==========================================
Files 279 279
Lines 10850 10900 +50
Branches 1496 1513 +17
==========================================
+ Hits 6720 6801 +81
+ Misses 3598 3563 -35
- Partials 532 536 +4 ☔ View full report in Codecov by Sentry. |
|
Add a platform version check for the version that added .NET8. If a user is redeploying we shouldn't break them. |
philasmar
force-pushed
the
asmarp/add-net8-beanstalk
branch
4 times, most recently
from
8d2d690 to
ca7d45d
Compare
philasmar
force-pushed
the
asmarp/add-net8-beanstalk
branch
from
ca7d45d to
1ccd396
Compare
| if (beanstalkPlatformSettingValueSplit?.Length != 3) | ||
| throw new InvalidElasticBeanstalkPlatformException(DeployToolErrorCode.InvalidElasticBeanstalkPlatform, $"The selected Elastic Beanstalk platform version '{beanstalkPlatformSettingValue}' is invalid."); | ||
| var beanstalkPlatformName = beanstalkPlatformSettingValueSplit[1]; | ||
| if (!Version.TryParse(beanstalkPlatformSettingValueSplit[2], out var beanstalkPlatformVersion)) | ||
| throw new InvalidElasticBeanstalkPlatformException(DeployToolErrorCode.InvalidElasticBeanstalkPlatform, $"The selected Elastic Beanstalk platform version '{beanstalkPlatformSettingValue}' is invalid."); |
There was a problem hiding this comment.
Is this format part of Elastic Beanstalk's "contract"? I would hate to penalize users by throwing an exception if EB ever changed the convention of these strings.
I'm wondering if it'd be safer to just proceed if we fail to parse, and possibly let the deployment fail, since users could then set Self Contained Build themselves to proceed.
Issue #, if available:
DOTNET-7212
Description of changes:
In order to support deploying .NET8 apps on Beanstalk prior to Beanstalk adding .NET8 support, we had to force .NET8 apps to be self-contained in order to allow for Beanstalk support. Beanstalk has since added .NET8 support, so this PR removes this restriction to allow .NET8 apps to be deployed to Beanstalk not as self-contained apps.
This PR also improves the sorting of Beanstalk platforms to show the latest .NET versions first.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.